[make:entity] Update ux-turbo package name to have proper suggestion #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfragnet
changed the title
nfragnet
changed the title
jrushlow
approved these changes
May 6, 2024
There was a problem hiding this comment.
@nfragnet - Thank you!
I'm not sure why the flex alias isn't working, but regardless, we're shifting to using the entire package name here in maker bundle rather than rely on flex aliases - so this is perfect.
Note to future self, we should utilize
forux-turbo and api bundles instead of throwing an error. This would behave like:
If you're up for that @nfragnet task, a PR would be much appreciated.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
I tried to create an entity using
bin/console make:entity --broadcastand got an error message suggesting a command to install the missing dependency. I think the command isn't working because the flex alias does not exist.I assumed that the correct dependency was
symfony/ux-turboand updated the MakeEntity class to declare the correct package name.